Skip to content

docs(navigation): Note about params + path #1680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 15, 2017
Merged

docs(navigation): Note about params + path #1680

merged 1 commit into from
Aug 15, 2017

Conversation

posva
Copy link
Member

@posva posva commented Aug 13, 2017

This isn't clear in the docs. #1679

@balint42
Copy link

Great additions, thanks! However there seem to be some typos in the code block:

  • line 38: missing ' after 'user
  • line 38: missing // before -> /user/123
  • line 39: missing // before -> /user/123
  • lines 38 & 39: different spacing between curly braces
  • line 40: perhaps better will NOT work instead of WON't work work

@posva posva force-pushed the docs/params-path branch from 6a64e43 to c7a3779 Compare August 13, 2017 16:19
@posva
Copy link
Member Author

posva commented Aug 13, 2017

Thanks, I made the modifications. About the spacing, this one:

router.push({ name: 'user', params: { userId }}) // -> /user/123

is intended (no multiple spaces between braces)

@balint42
Copy link

nice!

👍

@posva posva merged commit 86ca8a9 into dev Aug 15, 2017
@posva posva deleted the docs/params-path branch August 15, 2017 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants